Skip to content

PYTHON-5877 Consolidate CodeQL config into drivers-github-tools#2883

Merged
aclark4life merged 8 commits into
mongodb:masterfrom
aclark4life:PYTHON-5877
Jul 9, 2026
Merged

PYTHON-5877 Consolidate CodeQL config into drivers-github-tools#2883
aclark4life merged 8 commits into
mongodb:masterfrom
aclark4life:PYTHON-5877

Conversation

@aclark4life

@aclark4life aclark4life commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

PYTHON-5877

Blocked on: drivers-github-tools#108 — this PR currently pins to an unmerged commit on that branch (flagged by the code scanning bot). Once #108 merges, this PR needs a follow-up commit to re-pin codeql.yml to the resulting commit on main.

Depends on: drivers-github-tools#108 (merged) — codeql.yml is pinned to commit 95f9ce9 (tag v3) on main.

Changes in this PR

Replaces the inline CodeQL analysis steps with a call to the new
mongodb-labs/drivers-github-tools/codeql composite action
(drivers-github-tools#108).

The composite action centralises:

  • The pinned github/codeql-action hash (Dependabot updates it in one place for all drivers)
  • The checkout, Python setup, init, optional manual build, and analyze steps

The workflow in this repo retains only the repo-specific parts: triggers,
concurrency, matrix, and the paths-ignore config block.

Test Plan

  • The CodeQL workflow logic is unchanged — same languages, same build modes, same paths-ignore — only the location of the steps moved.

Checklist

Checklist for Author

- [ ] Did you update the changelog (if necessary)?
- [ ] Is there test coverage?

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

Delegate to the shared action so the pinned CodeQL version lives in
one place and Dependabot can update it centrally.
Copilot AI review requested due to automatic review settings June 18, 2026 15:46
@aclark4life aclark4life requested a review from a team as a code owner June 18, 2026 15:46
@aclark4life aclark4life requested a review from NoahStapp June 18, 2026 15:46
Comment thread .github/workflows/codeql.yml Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s CodeQL GitHub Actions workflow to delegate the CodeQL scanning steps to the shared mongodb-labs/drivers-github-tools/codeql composite action, keeping only repository-specific configuration (triggers, matrix, concurrency, and paths-ignore) in this repo.

Changes:

  • Replaced the inline checkout / setup-python / CodeQL init+analyze steps with a single call to mongodb-labs/drivers-github-tools/codeql pinned by SHA.
  • Updated the workflow inputs passed to CodeQL from languages to language, and moved the checkout ref into the composite action inputs.
  • Preserved the existing matrix and paths-ignore config block in this repo’s workflow.

Comment thread .github/workflows/codeql.yml
Comment thread .github/workflows/codeql.yml
@aclark4life

Copy link
Copy Markdown
Contributor Author

Companion to mongodb-labs/drivers-github-tools#108

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/codeql.yml Outdated
Comment thread .github/workflows/codeql.yml Fixed
Comment thread .github/workflows/codeql.yml Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/codeql.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@aclark4life aclark4life merged commit eb0b92f into mongodb:master Jul 9, 2026
88 checks passed
@aclark4life aclark4life deleted the PYTHON-5877 branch July 9, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants